Skip to content

Fix Clippy in shredding part 1: #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: shredding-variant-part1
Choose a base branch
from
Open

Fix Clippy in shredding part 1: #4

wants to merge 1 commit into from

Conversation

alamb
Copy link

@alamb alamb commented Sep 4, 2025

@alamb alamb mentioned this pull request Sep 4, 2025
Closed
@alamb alamb force-pushed the shredding-variant-part1 branch from 4d3cbde to 61bca91 Compare September 4, 2025 20:37
alamb
alamb commented Sep 5, 2025
View reviewed changes
parquet-variant-compute/src/variant_get/mod.rs
let mut obj = builder.new_object();
obj.insert("a", a_variant);
let mut a_obj = obj.new_object("x");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the API for making nested structures appears to have changed, so I updated the tests to use the new API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
parquet-variant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alamb